Giorgio Gilestro
f3ac65f8f7
Replaces the passive "by signing in you agree…" paragraph on /login with
an active un-pre-ticked checkbox over three short statements that the
user actively accepts. Each acceptance is recorded against a code-level
version pointer, so a future wording revision bumps the version and
prompts every user again.
- New app/legal.py::ACKNOWLEDGEMENT_VERSION (currently 1).
- New UserAcknowledgement model + migration 0027 (user_id FK CASCADE,
version, lang, accepted_at, composite index on user_id+version).
- auth_service: has_acknowledged_current() and record_acknowledgement()
helpers; POST /login validates the checkbox, falls through to a 400
with the localised error otherwise, and writes a row iff the user has
no current-version row (so existing-already-accepted users don't
produce duplicates).
- GET /login: language detection mirrors the landing's
detect_public_lang(); ?lang=en|it overrides; stamps the rtm.lang
cookie; passes the locale dict + version into the template.
- login.html: EN/IT pill, localised lede/banner/legal footer, required
checkbox in an acknowledgement block, hidden lang+ack_version fields.
Submit disabled until the box is ticked (UX polish; the server check
is what carries weight).
- locales/{en,it}.yaml: new auth.ack.* section with TODO(legal) marker.
Wording matches the brief's substance pending solicitor sign-off.
- tests/test_signup_acknowledgement.py: 10 tests (EN + IT rejection,
one row per acceptance, displayed-lang recorded, idempotent on
current version, version-bump writes new row, helper unit tests).
The acknowledgement strengthens the user-civil-claim vector — combined
with the liability cap and the Ltd, it makes "I was misled into thinking
this was advice" much harder to argue. It does NOT move the regulatory
perimeter, which is governed by the content discipline shipped in
47dce1a. Belt-and-braces, not a substitute.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
61 lines
1.7 KiB
Python
61 lines
1.7 KiB
Python
"""user_acknowledgements: affirmative sign-up acknowledgement audit table.
|
|
|
|
Revision ID: 0027
|
|
Revises: 0026
|
|
Create Date: 2026-05-29
|
|
|
|
One row per (user, version) acceptance of the /login acknowledgement.
|
|
See app/models.py::UserAcknowledgement and app/legal.py for context.
|
|
"""
|
|
from typing import Sequence, Union
|
|
|
|
import sqlalchemy as sa
|
|
from alembic import op
|
|
|
|
|
|
revision: str = "0027"
|
|
down_revision: Union[str, None] = "0026"
|
|
branch_labels: Union[str, Sequence[str], None] = None
|
|
depends_on: Union[str, Sequence[str], None] = None
|
|
|
|
|
|
def upgrade() -> None:
|
|
op.create_table(
|
|
"user_acknowledgements",
|
|
sa.Column(
|
|
"id",
|
|
sa.BigInteger().with_variant(sa.Integer(), "sqlite"),
|
|
primary_key=True, autoincrement=True,
|
|
),
|
|
sa.Column(
|
|
"user_id", sa.Integer(),
|
|
sa.ForeignKey("users.id", ondelete="CASCADE"),
|
|
nullable=False,
|
|
),
|
|
sa.Column("version", sa.SmallInteger(), nullable=False),
|
|
sa.Column("lang", sa.String(length=8), nullable=False),
|
|
sa.Column(
|
|
"accepted_at", sa.DateTime(timezone=True), nullable=False,
|
|
server_default=sa.text("CURRENT_TIMESTAMP"),
|
|
),
|
|
)
|
|
op.create_index(
|
|
"ix_user_acknowledgements_user_version",
|
|
"user_acknowledgements", ["user_id", "version"],
|
|
)
|
|
op.create_index(
|
|
"ix_user_acknowledgements_accepted_at",
|
|
"user_acknowledgements", ["accepted_at"],
|
|
)
|
|
|
|
|
|
def downgrade() -> None:
|
|
op.drop_index(
|
|
"ix_user_acknowledgements_accepted_at",
|
|
table_name="user_acknowledgements",
|
|
)
|
|
op.drop_index(
|
|
"ix_user_acknowledgements_user_version",
|
|
table_name="user_acknowledgements",
|
|
)
|
|
op.drop_table("user_acknowledgements")
|