feedback: thumb up/down on logs + reviewer self-score 0-10
Two unrelated features bundled because they ship together and share
migration 0028.
Strategic-log feedback (thumb up/down):
- New strategic_log_feedback table with UNIQUE(log_id, user_id) so each
user has one vote per log, flippable in place (up -> down -> clear).
UI shows aggregate counts only.
- app/services/log_feedback.py: set_vote, get_counts, sign/verify
feedback tokens (same itsdangerous pattern as auth.sign_pending,
30-day TTL for email links).
- POST /api/log/{id}/feedback: web vote, auth required, returns counts
+ the requesting user's own vote.
- GET /feedback?token=...&vote=...: email-link target, no auth, signed
token encodes (user, log, vote), renders feedback_thanks.html.
- partials/log.html: thumbs row below content, JS-driven swap via the
POST endpoint. Dashboard latest-log card and /log page both render
this partial via htmx, so the buttons appear in all three surfaces.
- digest emails: a "How was today's read?" row above the unsub footer,
with signed-token URLs against the latest StrategicLog at send time.
Plain-text fallback included.
Reviewer self-score (0-10):
- _SYSTEM_PROMPT asks for an integer score with anchors (10 exemplary,
5 borderline, 0 unfit). Verdict gains score: int | None.
- Deterministic-layer hits get score=0 (hard rule, no nuance);
error rows get None; LLM rows get the model's score clamped 0..10.
- ReviewerVerdict.score, StrategicLog.reviewer_score, and
IndicatorSummary.reviewer_score all new SMALLINT NULL columns.
- ai_log_job + indicator_summary_job persist verdict.score onto their
content rows when committing the row alongside content.
Tests:
- tests/test_strategic_log_feedback.py: vote, flip, clear, aggregate
across users, invalid vote, token round-trip + tamper + garbage +
'clear' not signable for email path.
- tests/test_output_review.py: score parsing, clamping (>10, <0),
missing/non-numeric -> None, deterministic-layer score=0.
Full suite: 427 passed (was 412), 5 skipped, no regressions.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
parent
f3ac65f8f7
commit
8946dee2e0
14 changed files with 962 additions and 14 deletions
30
app/templates/feedback_thanks.html
Normal file
30
app/templates/feedback_thanks.html
Normal file
|
|
@ -0,0 +1,30 @@
|
|||
{% extends "public_base.html" %}
|
||||
{% block title %}{{ BRAND_NAME }} · Feedback{% endblock %}
|
||||
|
||||
{% block main %}
|
||||
<section class="public-section" style="max-width:520px; margin:60px auto; text-align:center;">
|
||||
{% if ok %}
|
||||
<h1 class="public-section__head" style="margin-bottom:14px;">
|
||||
{% if vote == 'up' %}Thanks for the thumbs up.{% else %}Thanks for the thumbs down.{% endif %}
|
||||
</h1>
|
||||
<p style="color:var(--muted); font-size:14px; line-height:1.55;">
|
||||
Your vote on this strategic log is recorded.
|
||||
{% if counts %}
|
||||
Current tally: <strong>{{ counts.up }}</strong> 👍 ·
|
||||
<strong>{{ counts.down }}</strong> 👎.
|
||||
{% endif %}
|
||||
</p>
|
||||
<p style="margin-top:24px;">
|
||||
<a href="/" class="btn-primary">Open the dashboard</a>
|
||||
</p>
|
||||
{% else %}
|
||||
<h1 class="public-section__head" style="margin-bottom:14px;">Couldn’t record that vote</h1>
|
||||
<p style="color:var(--muted); font-size:14px; line-height:1.55;">
|
||||
{{ message or "Something went wrong; please try again from the dashboard." }}
|
||||
</p>
|
||||
<p style="margin-top:24px;">
|
||||
<a href="/" class="btn-primary">Open the dashboard</a>
|
||||
</p>
|
||||
{% endif %}
|
||||
</section>
|
||||
{% endblock %}
|
||||
Loading…
Add table
Add a link
Reference in a new issue