giorgio/read.markets
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

alembic: make migration chain SQLite-compatible (fresh upgrade)

Browse source 
Five existing migrations used op.alter_column / op.create_unique_constraint /
op.drop_constraint / op.create_foreign_key directly on the users + quotes +
quotes_daily tables. SQLite has no native support for those operations and
requires Alembic's batch_alter_table copy-and-rename workaround.

This wasn't noticed until now because the test suite uses
Base.metadata.create_all to materialise schema, not the migration chain
itself; and prod is MariaDB. But running `alembic upgrade head` against
a fresh SQLite database (developer onboarding, CI smoke tests, the
test container's own bootstrap) would fail at 0005.

Fixes:
- alembic/env.py: set render_as_batch=True when the dialect is SQLite.
  This auto-wraps any future autogenerated migration but doesn't
  retroactively rewrite existing op.* calls.
- 0005 (widen quotes.symbol), 0013 (referrals), 0018 (polar webhook),
  0019 (stripe), 0023 (users.lang index + qd_symbol widen) explicitly
  wrap their problematic ops in `with op.batch_alter_table(...) as bop`.

Now `alembic upgrade head` + `alembic downgrade base` round-trip cleanly
on a fresh SQLite database. MariaDB prod behaviour unchanged.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Giorgio Gilestro 2026-05-28 00:16:09 +02:00
parent 2b9cd875b4
commit 78ce8c8b0d
6 changed files with 79 additions and 74 deletions
Download patch file Download diff file Expand all files Collapse all files

24
alembic/versions/0019_stripe.py
View file

@ -18,17 +18,12 @@ depends_on: Union[str, Sequence[str], None] = None
def upgrade() -> None:
op.add_column(
"users",
sa.Column("stripe_customer_id", sa.String(length=64), nullable=True),
)
op.add_column(
"users",
sa.Column("stripe_subscription_id", sa.String(length=64), nullable=True),
)
op.create_unique_constraint(
"uq_users_stripe_customer", "users", ["stripe_customer_id"],
)
with op.batch_alter_table("users") as bop:
bop.add_column(sa.Column("stripe_customer_id", sa.String(length=64), nullable=True))
bop.add_column(sa.Column("stripe_subscription_id", sa.String(length=64), nullable=True))
bop.create_unique_constraint(
"uq_users_stripe_customer", ["stripe_customer_id"],
)
op.create_table(
"stripe_events",
@ -51,6 +46,7 @@ def upgrade() -> None:
def downgrade() -> None:
op.drop_index("ix_stripe_events_type_received", table_name="stripe_events")
op.drop_table("stripe_events")
op.drop_constraint("uq_users_stripe_customer", "users", type_="unique")
op.drop_column("users", "stripe_subscription_id")
op.drop_column("users", "stripe_customer_id")
with op.batch_alter_table("users") as bop:
bop.drop_constraint("uq_users_stripe_customer", type_="unique")
bop.drop_column("stripe_subscription_id")
bop.drop_column("stripe_customer_id")