From 9a46a0daece6b6ce573d1f16cb42d714de90c7d9 Mon Sep 17 00:00:00 2001
From: Giorgio Gilestro <giorgio@gilest.ro>
Date: Wed, 27 May 2026 14:55:29 +0200
Subject: [PATCH] =?UTF-8?q?portfolio:=20render=20hidden=20=C3=97=20per=20r?=
 =?UTF-8?q?ow;=20empty=20state=20shows=20add=20form?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
---
 app/static/js/portfolio.js      | 23 ++++++++++++++++++-----
 app/static/js/portfolio_edit.js | 14 ++++++++++++++
 2 files changed, 32 insertions(+), 5 deletions(-)

diff --git a/app/static/js/portfolio.js b/app/static/js/portfolio.js
index f030024..dfbcbfa 100644
--- a/app/static/js/portfolio.js
+++ b/app/static/js/portfolio.js
@@ -180,17 +180,22 @@
   function renderEmpty(mount) {
     const expired = consumeBackupExpiredNotice();
     const notice = expired
-      ? '<div class="settings-row__hint" style="margin-bottom:8px;">' +
-          'Your previous cloud backup couldn&rsquo;t be restored on this server. ' +
+      ? '<div class="empty-notice">Your encrypted cloud backup expired. ' +
           'Please re-upload your portfolio to refresh it.' +
         '</div>'
       : '';
+    var panel = document.getElementById('portfolio-panel');
+    if (panel) panel.classList.add('pf-empty');
     mount.innerHTML =
       '<div class="empty" style="padding:16px;">' +
         notice +
-        'No portfolio loaded in this browser. ' +
-        '<a href="/settings#import">Import a portfolio CSV →</a>' +
+        'Welcome — start by adding a position above, or ' +
+        '<a href="/settings#import">import a CSV from your broker →</a>' +
       '</div>';
+    // When empty, the add form should be visible by default — the
+    // edit module toggles it via the pf-empty class.
+    var form = document.getElementById('pf-add-form');
+    if (form) form.hidden = false;
   }
 
   // Silently remove an unrecoverable cloud blob and re-render. The user
@@ -265,6 +270,9 @@
   }
 
   function renderPanel(mount, pie, enriched, agg) {
+    var panel = document.getElementById('portfolio-panel');
+    if (panel) panel.classList.remove('pf-empty');
+
     const ccyPills = Object.keys(agg.by_currency)
       .sort((a, b) => agg.by_currency[b] - agg.by_currency[a])
       .map(c => {
@@ -293,6 +301,10 @@
         '<td class="num">' + lastDisplay + fxBadge + '</td>' +
         '<td class="num ' + cls(p._ppl) + '">' + signed(p._ppl) + '</td>' +
         '<td class="num ' + cls(p._ppl_pct) + '">' + pct(p._ppl_pct) + '</td>' +
+        '<td class="pf-row-del-cell">' +
+          '<button type="button" class="pf-row-del" data-idx="' + p._orig_idx + '" ' +
+                  'title="Remove this position" aria-label="Remove">\xd7</button>' +
+        '</td>' +
         '</tr>';
     }).join('');
 
@@ -349,6 +361,7 @@
           '<th class="num">Qty</th><th class="num">Avg</th>' +
           '<th class="num">Last</th><th class="num">P/L</th>' +
           '<th class="num">%</th>' +
+          '<th></th>' +
         '</tr></thead>' +
         '<tbody>' + rows + '</tbody>' +
       '</table>' +
@@ -483,7 +496,7 @@
     }
     const base = pie.base_currency || 'GBP';
     const fx = (universeCache && universeCache.fx) || null;
-    const enriched = pie.positions.map(p => enrichPosition(p, base, fx))
+    const enriched = pie.positions.map((p, i) => Object.assign(enrichPosition(p, base, fx), { _orig_idx: i }))
       .sort((a, b) => (b._value || 0) - (a._value || 0));
     const agg = aggregate(enriched);
     renderPanel(mount, pie, enriched, agg);
diff --git a/app/static/js/portfolio_edit.js b/app/static/js/portfolio_edit.js
index 68225f4..ff7b614 100644
--- a/app/static/js/portfolio_edit.js
+++ b/app/static/js/portfolio_edit.js
@@ -248,4 +248,18 @@
   }
 
   dateInput.addEventListener('blur', fetchHistorical);
+
+  // ---- Per-row delete (event delegation) -----------------------------
+
+  panel.addEventListener('click', function (e) {
+    const btn = e.target.closest('.pf-row-del');
+    if (!btn) return;
+    const idx = parseInt(btn.dataset.idx, 10);
+    if (!Number.isInteger(idx)) return;
+    const pie = window.CassandraPortfolio.loadPie();
+    if (!pie || !pie.positions || idx < 0 || idx >= pie.positions.length) return;
+    pie.positions.splice(idx, 1);
+    window.CassandraPortfolio.savePie(pie);
+    window.CassandraPortfolio.mountAndRender();
+  });
 })();